Issue 39: CMake support - I've added this - A free implementation of ADEPT protocol

Reported by Samuel Marks, Nov 27, 2022

CMake support would be handy, as would vcpkg integration.

I've just about finished, see branch `cmake` at 
https://github.com/SamuelMarks/libgourou

Want a patch? - Also done some `const` correctness stuff in that 
branch. - Would be good to `clang-format` the whole repo but am 
worried about killing patch history.

attac - 4.10 kB
attac - 4.10 kB
attac - 4.10 kB

Comment 1 by Samuel Marks, Nov 28, 2022

FYI: Just got it to work on vcpkg; building with CMake and 
everything: - https://github.com/microsoft/vcpkg/pull/28037

attac - 4.10 kB
attac - 4.10 kB
attac - 4.10 kB

Comment 2 by Grégory Soutadé, Nov 28, 2022

Hi Samuel,

I'm sorry, I forgot to merge your changes for MacOS, just did it.

The current changes are more complex as it impact build system and, 
to be honest, I would prefer you to keep it in a separate branch 
from your own.

attac - 4.10 kB
attac - 4.10 kB
attac - 4.10 kB

Status: WontFix

Comment 3 by Samuel Marks, Nov 28, 2022

All the tests pass, meaning macOS and Linux build perfectly on 
Azure: https://github.com/microsoft/vcpkg/pull/28037

If there is interest from you, I can port it to MSVC (Windows) also. 
But it's doubtful if I'll split these commits up into single file 
patches that I send you one-by-one. Can send it to you as one big 
patch though…

attac - 4.10 kB
attac - 4.10 kB
attac - 4.10 kB

Comment 4 by Grégory Soutadé, Nov 29, 2022

Nice. My principal concern about OS porting is maintenance as I 
don't use these systems. I don't want something too invasive. Plus 
we have ADE + Calibre on Windows. Don't think someone would use a 
command line tool like libgourou.

attac - 4.10 kB
attac - 4.10 kB
attac - 4.10 kB

Libgourou

Issue 39: CMake support - I've added this